search

laserpants / dotenv-cpp

:cow: A utility to load environment variables from a .env file
BSD 3-Clause "New" or "Revised" License
30 stars 12 forks source link

std::isspace needs the cctype header #5

Closed nagulv closed 1 year ago

nagulv commented 1 year ago

Hi Could you please accept this PR to include (needed by std::isspace) ? https://en.cppreference.com/w/cpp/string/byte/isspace

nagulv commented 1 year ago

I've also added a separate commit for the annoying Windows issue caused by min and max being defined as macros. One workaround is to add this on Windows:

#ifdef min #undef min #endif

but the workaround that feels cleaner to me is to just call the function (std::min)(x,y) like mentioned in this answer: https://stackoverflow.com/a/7449700

This prevents the macro expansion.

laserpants commented 1 year ago

Thanks @nagulv. I am going to update the version number and changelog info accordingly.