small changes - Githubissues

laserpants / qt-material-widgets

:art: Qt widgets-based implementation of the Material Design specification.

BSD 3-Clause "New" or "Revised" License

2.94k stars 660 forks source link

small changes #49

Open ashraf-kx opened 2 years ago

ashraf-kx commented 2 years ago

Supporting QT6
Can be used in CMake project
Moving all widgets inside a namespace called "md"
Muted the button issue related to high usage of CPU

Razzile commented 2 years ago

can widgets be used inside namespaces? I thought that caused issues with moc.

Also I think this project is abandoned unfortunately. I'd consider maintaining your own fork if you receive no response here

redtide commented 9 months ago

can widgets be used inside namespaces? I thought that caused issues with moc.

I'm about to fork this project and I think I'll remove all those "qtmaterial" prefixes in files and names, and use some qmw namespace instead, similar to what I did in my "SmartWidgets" project.

immagine

redtide commented 9 months ago

BTW this PR is something I would never merge if I were the maintainer, there are too many changes in a single place, you should make only one for CMake and other fixes in separated PR. It's an overkill to review.

I see a lot of PR around like this, and all almost unmerged, sometimes even without a single comment from the maintainer. Does people still have some empathy and/or good sense? If were yours, would you really merge something like this from another person to completely upset your project, even if correct?