lasley / docker-node-makemkv

Dockerized Node-MakeMKV
https://hub.docker.com/r/lasley/node-makemkv/
Other
4 stars 1 forks source link

Makemkv changed drive recognition #2

Open tobbenb opened 6 years ago

tobbenb commented 6 years ago

Hi. Not sure if you noticed, but the drive recognition is change from version 1.10.9. This means that you will have to pass through the correct /dev/sg device to the container also for the drive to be found. So both /dev/sg and /dev/sr is needed. The Makemkv author said that leaving out the /dev/sr device will impact performance. See here http://www.makemkv.com/forum2/viewtopic.php?f=3&t=16939&view=unread#p59822

TonyBrobston commented 5 years ago

@tobbenb I too found this to be the case. I'm glad you posted, it took me quite a bit to finally look in the issues tab to see your post and after trying to add sg's it helped.

My drives are /dev/sr0 and /dev/sr1, however my sg's were /dev/sg0 and /dev/sg3. I was surprised I couldn't just say /dev/sr* and /dev/sg*, docker didn't seem to like that.

I did a little googling and found that this works, however it's a lot of code for something so trivial. Something along the lines of: docker run $(for dev in /dev/sr*; do echo -n "--device $dev "; done) $(for dev in /dev/sg*; do echo -n "--device $dev:$dev "; done) lasley/node-makemkv:latest

I've now gotten past this hurdle, but am having another issue.