search

laslibs / lasrs

A rust library for parsing geophysical well log (.las) files
https://crates.io/crates/lasrs
6 stars 3 forks source link

more integration tests #4

Open iykekings opened 4 years ago

iambenkay commented 4 years ago

Hello there. I want to settle this matter. I have fair knowledge of rust and I would like to use this issue to exercise a bit. When you say integration tests, you mean actual test suites and not doc strings right?

iykekings commented 4 years ago

Yeah, check out tests/integration_test.rs for example

iambenkay commented 4 years ago

Alright thanks.

iambenkay commented 4 years ago

@iykekings while writing tests for Las.wrap() I noticed that all the .las files in ./sample are not wrapped. I would love one that is wrapped so that I can make sure the wrap function works in all cases.

iykekings commented 4 years ago

You can find more las files from here http://www.kgs.ku.edu/PRS/Scans/Log_Summary/index.html

iambenkay commented 4 years ago

Alright thanks.

iambenkay commented 4 years ago

I am spending most of my time just refactoring the tests into files and improving test coverage.

Just incase there are any domains of the program that tests have not been written for you can tell me so I'll do that.

iykekings commented 4 years ago

Yeah many exposed methods on the Las struct doesn't have test In the impl block of Las, check for functions with pub

iykekings commented 4 years ago

curve_params and log_params doesn't have integration tests. You can get an idea how to write tests for them from integration_test::well_sections. Also check their doc example

dcslagel commented 4 years ago

@iambenkay, @iykekings, would it be a good idea to make @iambenkay's current completed work a pull-request and move the new integration tests for curve_params, and log_params to a new issue?

iykekings commented 4 years ago

@dcslagel I will take a look at that...Thanks for pointing it out