search

lasote / conan-libcurl

Lib curl library package for conan
2 stars 12 forks source link

Added copying curl-config #7

Closed sztomi closed 3 years ago

sztomi commented 7 years ago

Some builds depend on curl-config to determine the path to libcurl include and lib directories. Setting prefix ensures that curl-config will return the conan package directory.

lasote commented 7 years ago

The problem is that the path will only be valid when the package has been generated in the same machine where the package will be used. I can accept the PR if it's useful for you, because I don't think it is going to break anything but take it in account that it won't work at least you build you own packages.

sztomi commented 7 years ago

oh, you are absolutely right. I tend to rebuild everything regardless if there is a package built so this never occurred to me. But no, don't merge it like this. If I add some steps to patch or replace the script with one that always works from the local package directory, would accept that as a PR?

lasote commented 7 years ago

Yes, if you could adjust the script to work properly I'll accept it, sure.