Simplify data types; implement causal context compression; methods for state-driven and digest-driven

[vitorenesduarte]

• [x] remove dot_set, dot_fun and dot_map from data type state
• [x] causal context compression
• [x] add property tests
• [x] remove nested types from composable data types state (e.g., state_gmap and state_pair)
• [x] implement necessary methods for state-driven and digest-driven synchronization algorithms

[cmeiklejohn]

Does this break @junghunyoo's implementation?

[vitorenesduarte]

Not sure, but I don't think so. #74 probably did break something, but it should be easy to fix.

[cmeiklejohn]

Hrm, this was merged with no review. Do these changes break compatibility with the Lasp code?

[cmeiklejohn]

@gyounes I would appreciate waiting for the CI to pass before just merging the code: this is the point of having continuous integration. This is a library that is used by more people than just the LightKone folks.

[vitorenesduarte]

I asked @gyounes to review this and CI tests passed. I had a PR in Lasp that fixes compatibility problem: Type:delta API changed.

[cmeiklejohn]

I'm just saying that prior to the CI passing it was merged according to GitHub.

On Thu, May 25, 2017 at 12:16 PM Vitor Enes notifications@github.com wrote:

I asked @gyounes https://github.com/gyounes to review this and CI tests passed. I had a PR in Lasp that fixes compatibility problem: Type:delta API changed.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/lasp-lang/types/pull/80#issuecomment-303975826, or mute the thread https://github.com/notifications/unsubscribe-auth/AACvizgzA_7xLslFjtBrOsbDMy9jvJqoks5r9VUSgaJpZM4Mjtbq .

[gyounes]

@cmeiklejohn You are totally right. That was a bit reckless from my side.