search

lasp / hapi-server

A HAPI server built on LaTiS
Apache License 2.0
1 stars 1 forks source link

HAPI-73 set Time metadata size in ToHapiTime #81

Closed JakeMartin99 closed 2 years ago

JakeMartin99 commented 3 years ago

Moves the mandatory setting of the size metadata for Time(s) to ToHapiTime, with constant value 24 because that is the known size of the always-used format: "yyyy-mm-ddThh:mm:ss.sssZ"

This currently passes all existing tests, including my recent DataService tests that use a Time domain but now no longer use directly-set size metadata for it. I am conflicted on whether more tests are needed....

lindholc commented 3 years ago

It is probably worth it to add a new test suite, with tests for both numeric and formatted times, that check that the operation gives us the right times and the right metadata.