search

lassefolkersen / highfrontier

The goal of High Frontier is a civilization-like game, which uses more realistic modelling of economy, climate, research and migration. Uniquely this game starts today - the initiation date of a game is todays date and the existing world is the world as we know it today, complete with cities and countries and people. The aim from there - that is whatever the player thinks the aim is for the world. Developing of the underdeveloping world, action against climate changes, expansion into the rest of the solar system, or just racking in a lot of money.
13 stars 3 forks source link

fixing problem when building as country and selecting very high values for firm size, issue #22 #23

Closed lassefolkersen closed 1 month ago

lassefolkersen commented 1 month ago

Minor thing, and probably only an issue in some edge case of playing as a country and building a food producing firm right away. But resulted in a crash nonetheless. Now fixed.

JonathanLochridge commented 1 month ago

Do you think this is ready to merge? I can try to do a test on my end after I look through it an then do the review if you think so?

It looks like a simple and sensible change for addressing it.

lassefolkersen commented 1 month ago

I think it's ready to merge, they were really minor things. I guess I should focus on making some more tests, instead of finding these things inside the game.

lassefolkersen commented 1 month ago

Thanks -- hey @lionel42 @JonathanLochridge if you use twitter, then check out this one (fun "multiply by 1000 challenge", i did CO2-effects 😄 )

JonathanLochridge commented 1 month ago

Well, if you enjoy finding little things in the game, or just happen to run into them while playing then there isn't any issue with trying to fix them as we find them.