search

lassekongo83 / adw-gtk3

The theme from libadwaita ported to GTK-3
GNU Lesser General Public License v2.1
1.43k stars 53 forks source link

Incorrect theming of the gnome software. #52

Closed DuttaAB-dev closed 1 year ago

DuttaAB-dev commented 2 years ago

All the app cards lack a shadow while using the adw-gtk3 theme.

libadwaita: image

adw-gtk3: image

Also the border colour is different.

Lastly, there is no padding at the bottom of the list view in the "software repositories" menu. I don't know if this is the same in other places as I havent' tested/noticed this anywhere else yet.

adw-gtk3: image

libadwaita: image

adwaita theme: image

lassekongo83 commented 2 years ago

I had the padding issue in nautilus preferences as well. I solved it with:

.preferences scrolledwindow > .frame > clamp {
  &.large, &.medium, &.small { padding-bottom: 30px; }
}

But from what I saw it was no preferences page, and I had only one row, so I couldn't test anything.

Since adwaita have it at normal padding, there must be some missing css somewhere.

xAspirus commented 2 years ago

shouldn't we focus only on the apps which are not going to be ported over to gtk-4?

DuttaAB-dev commented 2 years ago

shouldn't we focus only on the apps which are not going to be ported over to gtk-4?

I guess you are right, but then ubuntu is gonna stick to not using libadwaita while still using gtk4 apps without the libadwaita port, for example Nautilus 42. So maybe correcting the theming in this case might help in solving some issues in ubuntu 22.04

DuttaAB-dev commented 2 years ago

image Btw, commit bccba2288a87e4a19797c3656cb9db03377259da, i.e. the latest commit that you made on this issue did not fix it in my case.

juxuanu commented 2 years ago

Also, see the version rectangle and the links section. imatge