Incorrect colors for the page search box on Chromium/Google Chrome for light style scheme

lassekongo83 / adw-gtk3

The theme from libadwaita ported to GTK-3

GNU Lesser General Public License v2.1

1.56k stars 57 forks source link

Incorrect colors for the page search box on Chromium/Google Chrome for light style scheme #56

Closed rmnscnce closed 2 years ago

rmnscnce commented 2 years ago

Operating System: Fedora 35 Workstation x86_64 GTK3 version: 3.24.31 (packaged as gtk3-3.24.31-2.fc35.x86_64) Chromium/Google Chrome version: Google Chrome 98.0.4758.102 (Official Build) (64-bit) (packaged as google-chrome-stable-98.0.4758.102-1.x86_64) Git commit of theme: f7ed2ab

It appears that Chromium picks up the same color as the inactive omnibox background for the page search box background.

Examples:

adw-gtk3:

Adwaita:

rmnscnce commented 2 years ago

Additional information: It seems like applications set colors for text box backgrounds differently. GNOME Text Editor and the Adwaita Demo app have different opinions on how to color a text box:

GNOME Text Editor: white text box backgrounds, for both inactive and active states
Adwaita Demo: gray text box background, for both inactive and active states

I personally think GNOME Text Editor's colors are better for such fields.

lassekongo83 commented 2 years ago

@diego-pvlk Any input on how the chromium issue can be resolved, or if that's the intended look?

As for the second issue. This theme follows the styles that can be found in adwaita-1-demo and when using the libadwaita theme in gtk4-widget-factory, not the styles individual apps choose to use.

diegopvlk commented 2 years ago

I don't think it's possible to change the omnibox and search box individually, so you have to make a personal choice on which one looks better. I was trying to make the light omnibox looks more like nautilus pathbar.

The color to change is here: https://github.com/lassekongo83/adw-gtk3/blob/f7ed2ab0c6ec9954f40b75b6bba326ae6b5b8db5/gtk/src/adw-gtk3/gtk-3.0/_apps.scss#L601-L603