search

lassekongo83 / plano-theme

A flat theme for GNOME & Xfce4
GNU General Public License v3.0
208 stars 9 forks source link

The menu underline is not visible in VLC (2.2.6) #19

Closed kepler2 closed 6 years ago

kepler2 commented 7 years ago

Hello!

Thanks for you work.

I have found something. In VLC, the menu underline is not visible. (note that in Thunar, for example, is visible)

Underline: underline

No underline: no_underline

Thanks!

lassekongo83 commented 7 years ago

VLC is a not a GTK application, it's QT. That can cause the consistency to be a bit off on some parts of the theme as a side effect. In this case I believe the menubar in QT applications use a larger padding and can't read the one specified in the GTK theme.

kepler2 commented 7 years ago

Sorry I have an eye for consistency :), it would be nice to have consistent look between gtk / qt apps, but i guess it's up to you. (to be honest, the most consistent theme - not really the best looking and not really my favourite - is Arc theme. In this particular case, Arc theme has different selection highlight than Plano that it applies to both cases)

kepler2 commented 6 years ago

Hey :). So... there is no way to fix this? It doesn't happen for Greybird, Numix etc.

lassekongo83 commented 6 years ago

I can only modify the padding and the background color of the menuitem (but not the text color). QT apps can't use styles from the pixmap/pixbuf gtk2 engine which is required for the blue bottom line.

kepler2 commented 6 years ago

Hello.. i guess you are a more technical person. Maybe i was misunderstood... I was reffering to the selection indicator when you select a menu.

Here is a screenshot for Greybird theme (the selection is blue, as in the other apps) greybird

Another screenshot for Numix (the selection is light grey... or something :) numix

And the screenshot for Plano (no selection effect): plano

Thanks :)

lassekongo83 commented 6 years ago

The selection indicator is an image which can't be used in the QT-GTK style. I swapped the underline to a single color instead.

kepler2 commented 6 years ago

Thanks! Nice fix, now there is consistency between applications. (I tried in Thunar and VLC). Maybe some people will be upset because there is no underline anymore? :)