search

lasselupe33 / eslint-plugin-comment-length

MIT License
13 stars 3 forks source link

ignore URLs #1

Closed Zamiell closed 2 years ago

Zamiell commented 2 years ago

Hello and thanks for the lint rule!

Unfortunately, it triggers many false positives with URLs, like the following:

/**
  * This function is based on the following code:
  * https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/member-ordering.md
  */
function foo() {}

Would it be possible to add a ignoreUrls option that defaults to true, like ESLint's max-len rule does?

Thank you!

Zamiell commented 2 years ago

For future readers, I decided to fork this rule and implement the functionality myself: https://github.com/IsaacScript/isaacscript/tree/main/packages/eslint-plugin-isaacscript

lasselupe33 commented 2 years ago

Thanks for the pull request (#2) @Zamiell which fixes this.