lassik / emacs-currency-convert

Currency converter in Emacs
https://melpa.org/#/currency-convert
ISC License
1 stars 4 forks source link

Add defcustom for symbols to highlight in results buffer #3

Open articuluxe opened 4 years ago

articuluxe commented 4 years ago

Usually when I run I will only care about 1 symbol in the results list, and this would save scanning all of the symbols every time.

lassik commented 4 years ago

I agree - the source currency should be highlighted.

Do you know elisp, and if so, would you like to make a PR?

lassik commented 4 years ago

The conversions are in listed in alphabetical order, so that should help find the target currency quickly.

lassik commented 4 years ago

...and saves typing as well as letting you convert to more than one currency with the same effort and compare those amounts.

Perhaps the *Currency* buffer should be editable so you can delete the conversions you don't care about. You can already copy text from that buffer into another though.

lassik commented 4 years ago

Perhaps there should be a separate command M-x currency-convert-pair for people who only want one particular target currency to be shown.

Or M-x currency-convert could ask for the target currency, but it could be left blank (i.e. just press Enter at that prompt without typing anything) to show all conversions.

lassik commented 4 years ago

Or M-x currency-convert could ask for the target currency, but it could be left blank (i.e. just press Enter at that prompt without typing anything) to show all conversions.

I implemented this and pushed to master.