abiyasa
commented
6 years ago I tried to commented out the code which uses lasso-require (https://github.com/lasso-js/karma-lasso/blob/master/lib/framework.js#L19-L55) but it still fails.
I found out that one of the breaking changes from lasso 3 is that async API method returns promise instead of using callback. So changing this line with callback:
lasso.lassoPage(
fs.readJsonSync(process.argv[3]),
function(err, optimizedPage) {
if (err) {
console.error(err);
return process.exit(1);
}
var initFile = path.resolve(
outputDir,
'file-' + parseInt(Math.random() * 9999999) + '.js'
);
...
);to promise below, would solve some of the problems
lasso.lassoPage(lassoJson)
.then(function (optimizedPage) {
var initFile = path.resolve(
outputDir,
'file-' + parseInt(Math.random() * 9999999) + '.js'
);
...
fs.outputJsonSync(process.argv[4], files);
process.exit(0);
})
.catch(function (err) {
console.error(err);
return process.exit(1);
});Now, the only problem left is to replace parts which use lasso-require with something, which I don't know how.
Do you have any suggestion, is it safe to just remove that part @pranavjha ?
austinkelleher
pranavjha
The new lasso 3, released 3 weeks ago, merged lasso-require into lasso (see CHANGELOG). This breaks karma-lasso, which I accidentally found while making PR to ebay-font (https://github.com/eBay/ebay-font/pull/29).
When I run test that uses karma-lasso, I got the error "plugin module not found for lasso-require". Here's detailed error message from the last build of ebay-font:
I tried to remove lasso-require from karma plugin but it didn't work; I still got other error, complaining that
.test/output.jsonis not existed.Do you mind looking into this issue? Thanks a lot!