search

lasso-js / lasso-less

Lasso.js plugin to support compilation of less dependencies
7 stars 10 forks source link

Cannot use bootstrap as a npm dependency with lasso #12

Open meghakrishnamurthy opened 9 years ago

meghakrishnamurthy commented 9 years ago

When we install bootstrap from npm - I use browser.json to include the less files from bootstrap.

When I do this - it throws an error since bootstrap includes font in the following format:- https://github.com/twbs/bootstrap/blob/master/less/glyphicons.less#L13-L18

As seen in lasso-less doc it is not the recommended way - https://github.com/lasso-js/lasso-less#urls

This makes it extremely hard to use bootstrap via lasso.

Secondly - I created a package that changed URL variables to relative path and published it as ebay-bootstrap, but I noticed that it fails because it is not able to publish woff2 format to the resource server. https://github.com/twbs/bootstrap/blob/master/less/glyphicons.less#L15

Woff2 is not yet supported and hence it causes errors.

patrick-steele-idem commented 9 years ago

Hi @meghakrishnamurthy, for the first issue, are you seeing an error? If so, what is the error that you are seeing? Even though it is not recommended to put variables inside a URL, lasso will still attempt to resolve the URL and in 90% of cases it should work as expected.

For the second issue, we are tracking this internally and I will share the details with you offline.

meghakrishnamurthy commented 9 years ago

@patrick-steele-idem For issue 1 - Yes I was seeing an error and getting a PNR while accessing my pages. Right now since I updated to use the customized bootstrap, I am not seeing that issue. I can revert the changes and send the exact error that I was getting.

For issue 2 - let us sync up offline.