search

lasso-js / lasso-marko-taglib

A taglib to use Marko with Lasso
MIT License
9 stars 8 forks source link

module [@lasso/marko-taglib] is using deprecated features #20

Open jasonfutch opened 5 years ago

jasonfutch commented 5 years ago

Running version 1.0.15 and receive the following warning.

The module [@lasso/marko-taglib] is using deprecated features.
Run with process.env.SHOW_MODULE_COMPLAINS=1 to see all warnings

When I enable SHOW_MODULE_COMPLAINS it shows the following error.

addNestedVariable is deprecated. Use tag parameters instead.
  at node_modules/@lasso/marko-taglib/taglib/lasso-resource-tag-transform.js:34:30
jasonfutch commented 5 years ago

Any thoughts?

manuel-di-iorio commented 4 years ago 
The module [@lasso/marko-taglib] is using deprecated features.
Run with process.env.SHOW_MODULE_COMPLAINS=1 to see all warnings

marko 4.21.1 lasso 3.3.1 lasso-marko 2.4.9 @lasso/marko-taglib 1.0.15

When setting this process.env.SHOW_MODULE_COMPLAINS=1 (1 or 0, no difference) it throws this red warning in the console:

WARNING!!
package-path - attribute path type is deprecated
nelder commented 4 years ago

Same

DanielVip3 commented 4 years ago

Still to today. It feels nonsense that after a year this deprecation warning hasn't been fixed. And nothing is said in marko's source code, where only a deprecation warning is called without saying what you should use instead.

DanielVip3 commented 4 years ago

I made a pull request to fix this issue: #23 . You can install this lib from that repo itself, like this

npm i --save https://github.com/DanielVip3/lasso-marko-taglib/tarball/master

This library seems no longer mantained, so I don't think they'll ever accept them.