search

lasso-js / lasso-minify-css

Transform for Lasso.js to minify CSS using sqwish
0 stars 2 forks source link

Sqwish => uglifycss #3

Open CharlesWall opened 7 years ago

CharlesWall commented 7 years ago

Sqwish has open issues and hasn't had a commit in 3 years.

https://github.com/ded/sqwish/issues/10

lets use this. https://www.npmjs.com/package/uglifycss

austinkelleher commented 7 years ago

Hey, @CharlesWall thanks for opening this issue. We are aware that Sqwish has bugs and is outdated. I opened up this PR (https://github.com/lasso-js/lasso-minify-css/pull/2) a long time ago and it never got merged. What do you think about switching to clean-css instead?

austinkelleher commented 7 years ago

We should revisit my old PR. I'm currently in the process of making some large refactors to Lasso (https://github.com/lasso-js/lasso/pull/222). In these changes, we are pulling in core Lasso plugins into Lasso, so this plugin will become part of Lasso core in Lasso v3.

CharlesWall commented 7 years ago

I think clean-css looks like a good choice. There are no serious bugs and it looks well maintained.