search

lasso-js / lasso

Advanced JavaScript module bundler, asset pipeline and optimizer
582 stars 75 forks source link

Inline CSS / JS for whole application through config #129

Closed RajaRamu closed 8 years ago

RajaRamu commented 8 years ago

Currently, inline resources is possible only in the component level like { "path": "b-c2c-banner.less", "inline": true, "slot": "amp-slot” }. Requesting to have application level flag to control this. this would be helpful for site speed testing. Once master application level inline:true set, it should override all the components below.

As you all know, inlining the CSS speeds up the start rendering(proved in desktop). we want to test this feature on mobile

patrick-steele-idem commented 8 years ago

Thanks for opening this issue. We'll definitely be taking a closer look to see how we can implement this, but at this point I can't give you an exact timeline. Please let me know how important this feature is to you and it will help us prioritize.

Thanks!

RajaRamu commented 8 years ago

we are targeting next release by end of may. please let me know if you could make it by then

patrick-steele-idem commented 8 years ago

Ok, good to know. I'll see if we can squeeze this into our next sprint.

patrick-steele-idem commented 8 years ago

This feature has been implemented as part of the following plugin: https://github.com/lasso-js/lasso-inline-slots