lasso-js / lasso

Advanced JavaScript module bundler, asset pipeline and optimizer
581 stars 75 forks source link

Defining bundles with "intersection" does not work for "require" dependencies #180

Closed philidem closed 7 years ago

philidem commented 7 years ago

We currently allow something like in the lasso configuration:

bundles: [
    {
        name: 'common',
        dependencies: [
            {
                intersection: [
                    dependency1,
                    dependency2
                ]
            }
        ]
    }
]

However, in this example if dependency1 and dependency2 transitively include other require dependencies then the intersection is not properly calculated due to some de-duplication logic in lasso-require.