search

lasso-js / lasso

Advanced JavaScript module bundler, asset pipeline and optimizer
581 stars 75 forks source link

Fix for broken timeout parameter #188

Closed bparmer closed 7 years ago

bparmer commented 7 years ago

The switch from page-tag to config-tag in this PR is breaking our builds, since slot-tag.js reads the timeout parameter from lassoRenderContext.data.timeout.

patrick-steele-idem commented 7 years ago

Thanks for the PR @bparmer (sorry about the broken build!). I've assigned this to Michael to review.

mlrawlings commented 7 years ago

@bparmer Thanks for catching this and taking the time to look into it! I've published lasso@2.11.1 with the fix.

bparmer commented 7 years ago

That fixed it! Thanks for the help @patrick-steele-idem and @mlrawlings!