Support Node.js >= v10 with proper SemVer check

lasso-js / lasso

Advanced JavaScript module bundler, asset pipeline and optimizer

582 stars 75 forks source link

Support Node.js >= v10 with proper SemVer check #270

Closed Piezoid closed 6 years ago

Piezoid commented 6 years ago

Node.js >=v10 was recognized as >= v8.0, triggering the compat mode. The right thing to do seems to use the semver module.

Tests pass locally fine except:

lasso-lassoResource-buffer: expected '/static/cf6691ad.png' to equal '/static/02827b0c.png'
lasso-lassoResource-buffer-name: expected '/static/test-cf6691ad.png' to equal '/static/test-02827b0c.png'

I use the nodejs-10.1.0-1 package on Arch Linux. tag/v3.1.5 fails in the same way. Maybe a random number generator seed change ?

austinkelleher commented 6 years ago

Hey @Piezoid. Looks like there is an issue with Node 6 in the latest build after I added Node 10 to Travis. Your PR looks good, but we are going to try and figure out the build failure before publishing a new version. We'll let you know when this gets published.

Piezoid commented 6 years ago

Thanks for the quick merge !

The Travis log shows the same test failure happening on my computer (hash is cf6691ad on Node 10). It looks like a hashing algorithm/seed change between all the versions. It's curious that the change between v6 and v8 is appearing only now.

The release can wait, lasso is functional in compat mode on Node 10.