search

lasso-js / lasso

Advanced JavaScript module bundler, asset pipeline and optimizer
582 stars 75 forks source link

minifyInlineOnly breaks with lasso 3.2.0 #272

Closed scttdavs closed 6 years ago

scttdavs commented 6 years ago

Lasso recently updated uglify-js to v3. With that new change, this now breaks: https://github.com/lasso-js/lasso/blob/master/src/plugins/lasso-minify-js/index.js#L5

as the plugin config of:

{ inlineOnly: true }

is passed to uglify-js, which in turn fails due to an unrecognized option. That option is meant for lasso, not uglify-js, so it should not be passed to it. This appears to be a new behavior for uglify-js with the upgrade from v2 to v3.

DylanPiercey commented 6 years ago

Fixed in v3.2.2 😄