do not pass lasso options to uglifyjs Fixes #272

lasso-js / lasso

Advanced JavaScript module bundler, asset pipeline and optimizer

580 stars 75 forks source link

do not pass lasso options to uglifyjs Fixes #272 #275

Closed scttdavs closed 5 years ago

scttdavs commented 5 years ago

The details of the issue can be found here: https://github.com/lasso-js/lasso/issues/272

austinkelleher commented 5 years ago

Thanks for the change @scttdavs! See my comment above. Curious on your thoughts.

/cc @mlrawlings @DylanPiercey

DylanPiercey commented 5 years ago

😞. So I would say rather than whitelist uglify options we should filter out our lasso minifiyjs options. It looks like the only option other than minify options that are added by lasso is inlineOnly, I'll put up a PR that removes that.

scttdavs commented 5 years ago

ah, didn't realize there was a way to pass options to this since it was an internal plugin. I'll close this one then.