search

lassoan / SlicerElastix

This extension makes available Elastix medical image registration toolkit (http://elastix.isi.uu.nl/) available in Slicer.
MIT License
49 stars 29 forks source link

Elastix not found on Mac #4

Closed pieper closed 5 years ago

pieper commented 7 years ago

Installed SlicerElastix extension but it failed to find elastix.

Setting the path manually to this works:

/Applications/Slicer-4.8.0.app/Contents/Extensions-26489/SlicerElastix/lib/Slicer-4.8

looks like a simple script change fixes this - I'll make a PR

pieper commented 7 years ago

Wait - looks like this was already fixed on master but not 4.8. Would be good to bump the 4.8 hash.

jcfr commented 7 years ago

Would be good to bump the 4.8 hash.

👍

The easiest would be cherry pick all commit from 4.9 back onto the 4.8 release branch.

lassoan commented 7 years ago

Ok, I'll do that today.

jcfr commented 7 years ago

Since I add already a source tree ready based on these instructions.

I run the following command:

cd Slicer-4.8
git fetch origin
git cherry-pick 37ac135
git cherry-pick 06dd46d..2982333
git svn dcommit --add-author-from
git push origin git push origin master-48

The branch on SVN and on Github have all commit from 4.9 backported except the one labelled ENH: Begin 4.9.0 development

http://viewvc.slicer.org/viewvc.cgi/Slicer4/branches/Slicer-4-8/ https://github.com/Slicer/Slicer/commits/master-48

jcfr commented 7 years ago

Next steps are:

Whenever you think we are ready, we can release ...

lassoan commented 6 years ago

Is this still an issue? Does SlicerElastix works on Mac using 4.8 and nightly Slicer?

jcfr commented 6 years ago

It is on my list before cutting 4.8.1.

On Dec 13, 2017 9:05 PM, "Andras Lasso" notifications@github.com wrote:

Is this still an issue? Does SlicerElastix works on Mac using 4.8 and nightly Slicer?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lassoan/SlicerElastix/issues/4#issuecomment-351585723, or mute the thread https://github.com/notifications/unsubscribe-auth/AANXo81Kl77dKtDFzubXBgcqsaIokS-tks5tAIJMgaJpZM4Qajzv .

lassoan commented 6 years ago

Is this still an issue? Does SlicerElastix works on Mac using 4.10 and nightly Slicer?

lassoan commented 5 years ago

This should fix the Mac build: https://github.com/lassoan/SlicerElastix/commit/bfe0d9786e138a3a46df5b4022281cd49d844043

lassoan commented 5 years ago

Also had to update Elastix to latest version. It should work in tomorrow's nightly build.

lassoan commented 5 years ago

This should work correctly now.