Case sensitive comparisons

[indented-automation]

The code in this module makes significant use of .Contains to look for sub-strings. For example:

$exePath.Contains('powershell') -or $exePath.Contains('cmd')

However, the .Contains method of System.String is case-sensitive and, in win PS (.NET Framework), has no overloads available to make ignore case.

This use of .Contains will yield false and you'll miss things:

$exePath = 'c:\somepath\PowerShell.exe'
$exePath.Contains('powershell')

I suggest one of:

• Use a PS operator such as -match. For example: $exePath -match 'powershell'
• Convert incoming strings to the same case for the purpose of comparison. For example: $exePath.ToLower().Contains...
• Substitute use of this method for another that supports case insensitive comparisons. For example: $exePath.IndexOf('powershell', [StringComparer]::OrdinalIgnoreCase) -gt -1

[last-byte]

Totally agree, I will fix this in the next release. Sorry for the late reply.

[last-byte]

I fixed the .Contains issue where it impacted the operation of the module by setting the compared strings to lowercase. In many cases it's just a sanity check and it wouldn't have changed anything to switch to another type of operand.