lastbattle / Harepacker-resurrected

All in one .wz file/map editor for MapleStory game files
Mozilla Public License 2.0
426 stars 159 forks source link

old school maple incompatibility? #194

Closed izarooni closed 1 year ago

izarooni commented 1 year ago

https://github.com/lastbattle/Harepacker-resurrected/blob/da76894e07bcf9b87ae4dfb11dbaca799ccfc8bb/MapleLib/WzLib/WzDirectory.cs#L274

This added line causes certain nodes to not parse on custom old school files I was using. The checksum I saw when debugging was 0 causing the if-statement to fail.

During testing I saw no issues with changing it to a greater than or equal to condition assuming the checksum is always positive, I know sometimes they can be negative. But if both cases are possible couldn't this statement be removed?

Tested using custom v83 files (GMS encryption) and latest official MapleStory files via steam download.

Edit: I see how the checksum works now. I don't know how mine was 0 but in any case I hope this may help anyone in a similar situation