search

lastbattle / Harepacker-resurrected

All in one .wz file/map editor for MapleStory game files
Mozilla Public License 2.0
416 stars 156 forks source link

fix loading v83 files #216

Closed Souna closed 1 year ago

Souna commented 1 year ago

tbh idk why there's a check here but disabling it allows v83 files to function correctly in the editor again. This makes it possible to load the maps in the map selector. Previously the map selector would show the map names but not allow you to load them.

lastbattle commented 1 year ago

Reverting this might cause issues for later version of MapleStory (post- v64 clients). Will look into better ways of fixing this instead.

lastbattle commented 1 year ago

I'll merge this first.

Souna commented 1 year ago

Out of curiosity what other features are you working on implementing for HaCreator?

lastbattle commented 1 year ago

Writing my own libs for handling UI window I guess, still a work-in-progress. Been quite busy lately. Gif output2

Arnuh commented 1 year ago

I tested multiple versions of pre-bb and maps loaded fine, what was even broken?

lastbattle commented 1 year ago

Custom server WZ files?

Souna commented 1 year ago

Yes. Forgot to clarify it wasn't working for private server files. For example, MapleRoyals wz. I haven't tested it on unmodified pre-bb files so this PR may not make sense anymore. It would be good to have it work for both however

Arnuh commented 1 year ago

I guess it's fine then, editing someone elses wz files isn't a reason to remove it but clearly it's not a good check due to GMS accepting the files(I'd assume, not sure if they've just removed a check themselves).