search

lastfm / lastfm-desktop

The official Last.fm desktop application suite
http://www.last.fm
GNU General Public License v3.0
462 stars 94 forks source link

Update app/client/Dialogs/DiagnosticsDialog.cpp #14

Closed kant closed 11 years ago

kant commented 11 years ago

Spanish translation of this diagnostics dialogs.

erik commented 11 years ago

I'm not affiliated with the project, but translations like this typically are contained within the relevant translation files (i18n/lastfm_es.ts in your case), not the source itself, as the English version is used as a key for the other languages to base their translations off of.

Unless this project has a different process for contributing translations, you should probably make your changes to the i18n/lastfm_es.ts file instead.

See for example this commit: a1b393e0f46

eartle commented 11 years ago

Yep, @boredomist is correct. The text in the source files is used as IDs and the actual text used in the app comes from the translation files in the i18n folder. For Spanish i18n/lastfm_es.ts.

In this case however, these stings are commented out and unused: they are not in the app, don't need to be translated, and don't appear in the translation files.

Thanks for taking the time to try to improve the app though!