search

lastfm / lastfm-desktop

The official Last.fm desktop application suite
http://www.last.fm
GNU General Public License v3.0
461 stars 94 forks source link

Support Scrobbling on MacOS Catalina #69

Closed stephen-dooley closed 4 years ago

stephen-dooley commented 5 years ago

Breaking changes in MacOS Mojave:

MacOS Mojave introduces more stringent permissions surrounding AppleEvents. We must include NSAppleEventsUsageDescription in the plist to grant the app permissions to talk to other apps via AppleEvents.

Breaking changes in MacOS Catalina:

MacOS Catalina no longer comes installed with iTunes (replaced with Apple Music). We need to detect which music player is installed to support Scrobbling on Catalina.

stephen-dooley commented 5 years ago

This looks great, although there are a few things which need tidying.

I'm not (yet) convinced about using homebrew QT. Should probably just peg it to a particular checked-out version.

Yet to see the change where we fix the "Open iTunes" button the app. But, this is great,

Would be good to tackle the "Open iTunes" button issue in a separate PR just to isolate the work. Not sure yet what's involved, although I know where the code for generating the button is.

Re. homebrew QT - we should have a talk about pegging qt to a version. But also feels like a separate PR. Doesn't feel like it's related to fixing scrobbling.

stephen-dooley commented 4 years ago

@ben-xo I reverted the change we made to point the plugins path to the homebrew Cellar. It breaks the build. You can see the error in my last commit message.

Are there any other issues with this PR?