lastfm / lastfm-windows-desktop

Last.fm Desktop app for Windows (3.0)
GNU General Public License v3.0
10 stars 2 forks source link

Add a popup when authenticated #21

Closed ben-xo closed 7 years ago

ben-xo commented 7 years ago

As the window now disappears by itself, we would like a popup notification saying "Now scrobbling as " when auth completes.

As the app now gives this feedback, we would also like the other popups off by default.

Can we combine the other popups into one setting, too, please? :) (popups on or off)

VorTechS commented 7 years ago

I'm not not keen on the combining of the popups on/off into one setting. Having used the app for the last few hours, I want to be able to turn off the 'Scrobble' notifications but keep the 'Now playing' notification.

ben-xo commented 7 years ago

So the only reason I wanted them in the first place was to show that the app is working - but I expect the "popup after authentication" to do that function now too

I actually think that after testing, we'll probably want these to default to off. I'll wait for further feedback before pursuing, though.

VorTechS commented 7 years ago

Would it be silly to have a check-box that 'Enables' notifications, but then enables the two existing options so that the user has granular control?

ben-xo commented 7 years ago

If you can make it look uncomplicated, go for it.