lastfm / lastfm-windows-desktop

Last.fm Desktop app for Windows (3.0)
GNU General Public License v3.0
10 stars 1 forks source link

Should not show "Successfully scrobbled…" popup if the scrobble was rejected #23

Closed ben-xo closed 6 years ago

ben-xo commented 6 years ago

Expected:

Actual:

Generally, should ignore tracks from iTunes with - as artist and title are both mandatory

There are other examples which will fail, though, such as tracks called "Track 1". (You don't have to filter these out - just don't show the popup.)

Steps to reproduce:

ben-xo commented 6 years ago

image

VorTechS commented 6 years ago

This is a side-effect of removing the 'Accepted, Rejected' part of the notification. Presumably we want to just suppress the popup if there were no accepted scrobbles?

ben-xo commented 6 years ago

That's right.

VorTechS commented 6 years ago

This has been addressed by a previous commit.