search

lastfm / lastfm-windows-desktop

Last.fm Desktop app for Windows (3.0)
GNU General Public License v3.0
10 stars 1 forks source link

Pausing then resuming Scrobbling doesn't re-instate current track name on UI #33

Closed VorTechS closed 6 years ago

VorTechS commented 6 years ago

Pausing then resuming Scrobbling doesn't re-instate the current track name on Ui until the next track plays.

VorTechS commented 6 years ago

Notes for myself for later:

Modify the .IsEnabled property to make it a private set, and use this property purely for representing the enabled state (as per settings).

Add specific entry point functions for 'ResumeScrobbling' and 'StopScrobbling' to control the behaviour of the plugin, and have the 'ResumeScrobbling' function return the current media item (so pause/unpause also works). Use the return result from 'ResumeScrobbling' to populate the Ui.

VorTechS commented 6 years ago

I added a new Scrobbler Factory method to allow plugins to push media updates based on the current state of the media player, as often as a poll occurs. Whilst the Ui is not reflecting this change, the addition of the current track into the context menu, means this bug was still valid.