search

lastfm / lastfm-windows-desktop

Last.fm Desktop app for Windows (3.0)
GNU General Public License v3.0
10 stars 1 forks source link

Incorrect "Successfully scrobbled x track(s)" notifications (wrong number) #38

Closed lauranolte closed 6 years ago

lauranolte commented 6 years ago

Setup:

Actual behaviour:

When a track has finished, and a scrobble has been submitted, I'm seeing the notification that says "Successfully scrobbled 50 track(s)" or I had 34 tracks as well just now.

I don't know if it's actually submitting that many scrobbles, or if only the notification is wrong. I'm scrobbling just one track.

VorTechS commented 6 years ago

If you go into Windows Explorer (NOT Internet explorer), in the address bar enter:

%appdata%\LastFM\Desktop Scrobbler\v3\Cache

...are there any files in there?

VorTechS commented 6 years ago

I think is down to the fix that I applied this afternoon, where there was a bug meaning that cached scrobbles weren't being sent. It sounds like you had 84 cached items, but the notification is occuring inside a loop that adheres to the 'Send only 50' rule. I'll move this notification out of that loop.

lauranolte commented 6 years ago

No, I'm not seeing anything in that place.

VorTechS commented 6 years ago

I'd expect not given that the Scrobble took place.

I've fixed the notification system so that it only displays one message per scrobble 'round' irrespective of how many tracks get sent in batches.

lauranolte commented 6 years ago

FWIW, when scrobbling from WMP it's correctly showing me "Successfully scrobbled 1 track(s)"

VorTechS commented 6 years ago

Aha! Such important information that! Turns out there was logic flaw I'd fixed in WMP but not in iTunes, so for every second over the 'Can scrobble' time, the track was being pushed to the scrobble queue.

lauranolte commented 6 years ago

Thanks, this is working for me now.