search

lastfm / lastfm-windows-desktop

Last.fm Desktop app for Windows (3.0)
GNU General Public License v3.0
10 stars 1 forks source link

Small UI tweaks #46

Closed ben-xo closed 6 years ago

ben-xo commented 6 years ago

  1. "Select the Scrobbler Plugins to Enable" -> lowercase e on enable

  2. We need to add a link to "Terms of Use" (https://www.last.fm/legal/terms) somewhere in the UI. Maybe next to the version. Probably also in the installer?

  3. Popup notifications should have all text with the same alignment (not half left, half center)

VorTechS commented 6 years ago

No. 3 Got an example please?

VorTechS commented 6 years ago

No 2: I don't think we can do that on the installer. I'll fit the URL at the bottom of the main UI (once I've migrated the settings into a single form)

VorTechS commented 6 years ago

Minor Ui fixes done. Need an example of 'mis-alignment' as all popup notifcations use the same window, with no adjustments. Title and body are all centered in their allocated region/rectangle.

VorTechS commented 6 years ago

I'm going to close this one. I think the notification issues are fixed, and No. 2 relates to the notifications not correctly sizing, meaning they would have not looked right.

ben-xo commented 6 years ago

The centering is still weird because of the way the components are nested in the popup

What it does now is

[=====TITLE======] [IMG][===TEXT====]

What it should probably do is [IMG][====TITLE====] [IMG][====TEXT====]

if you see what i mean

VorTechS commented 6 years ago

I can certainly move the 'Title' to be in line with the body text.

VorTechS commented 6 years ago

Modified the Title to span the same width as the body text, and moved the logo to 'middle' it