A track that is > 30 but < 60 seconds doesn't scrobble

lastfm / lastfm-windows-desktop

Last.fm Desktop app for Windows (3.0)

GNU General Public License v3.0

10 stars 2 forks source link

A track that is > 30 but < 60 seconds doesn't scrobble #57

Closed lauranolte closed 6 years ago

lauranolte commented 6 years ago

Setup:

Windows 10
Scrobbler 3.1.6.9
Scrobbling from iTunes 12.7

Steps:

Play a track that is over 30 seconds, but under 1 minute long; e.g. Death Grips — 5D from https://www.last.fm/music/+free-music-downloads?page=2

Actual behaviour:

The track doesn't scrobble, while longer tracks scrobble OK

Expected:

Tracks that are at least 30 seconds long scrobble OK

VorTechS commented 6 years ago

@lauranolte Does the same track scrobble okay from Windows Media Player?

lauranolte commented 6 years ago

I have problems scrobbling from WMP at the moment. (I think the plugin isn't enabled (though I have a Last.fm plugin enabled within WMP), I can't check in the Scrobbler because I'm still seeing https://github.com/cbsimg/lastfm-windows-desktop/issues/51)

lauranolte commented 6 years ago

It doesn't scrobble in WMP either.

Maddieman commented 6 years ago

I can reproduce the issue in both WMP and itunes. (3.1.6.50)

I have track 36s long and it no longer scrobbles (it used to work in 3.1.5.. ). It says track scrobbled, but doesn't appear in my library.

VorTechS commented 6 years ago

Thanks. I can see the reason for the failure, and am working on fixing it!

VorTechS commented 6 years ago

A logic flaw comparing minimum scrobble time against current playing time for exactness meant there was never any chance of tracks < 60 seconds reaching a scrobble state. This logic has been modified to remove exactness.

Maddieman commented 6 years ago

[ver. 3.1.9.28] I'm still seeing this issue with my 36s track, but it's not consistent. Sometimes it scrobbles, sometimes it doesn't.

lauranolte commented 6 years ago

The 0:43 long Death Grips track now scrobbles for me from iTunes and WMP with 3.1.9.28

The 0.36 long test track seems to be scrobbling OK from WMP, but not properly from iTunes (only scrobbled once out of 5 or so attempts).

VorTechS commented 6 years ago

Try the build Ben gives you tomorrow / today (depending on when you read this!) I've been able to drastically improve the scrobble tracking for iTunes and tested it with both shorter and longer tracks (36s, 45s, 4 & 5 minutes) and everything seems to be wroking as it should.