Scrobble logic changes

[ben-xo]

I'd like the scrobble logic to work like this:

• playing a song starts a timer pausing stops the timer, unpausing resumes stopping or changing tracks triggers the "should it scrobble?" logic ** "should it scrobble?" = (timer > 15s) && (timer > min( (song length / 2), 5 minutes ) )
• if "should it scrobble?" ** immediately write to cache (in case we crash or the laptop runs out of power…)

Flushing the cache is then done at other convenient opportunities:

• when the songs change
• when connectivity permits, if a previous attempt failed
• startup
• shutdown

[VorTechS]

Scrobble logic modified, scrobbles now occur immediately when a connection is available or cached if not, according to the track length / 2 or a minimum of 5 minutes is reached.

iTunes doesn't have 'Pause' in it's playstate model. It's either, playing, stopped or winding back/forwards. However, we're now treating stopped as paused.

[ben-xo]

So this doesn't yet work how I was expecting

It still sends the scrobble (and does the popup) immediately after the "scrobble point", not at the end of the song.

I think the fix for this is to only try to flush the scrobble queue after the song has changed / ended / etc. (Including shutdown or expiry of 5 minutes).

(If that flush fails, because you're offline, then of course flush whenever you get a chance).

[VorTechS]

Noted. Will modify accordingly.

[VorTechS]

The scrobble at end of track, was covered by an earlier check-in.