search

lastguest / murmurhash-php

PHP userland implementation of MurmurHash3
MIT License
128 stars 37 forks source link

PHP8 support #11

Closed afk11 closed 3 years ago

afk11 commented 3 years ago

Hi

This PR adds support for PHP8.0. I tried against a couple of PHP versions, tests run on 7.3, 7.4, 8.0. I don't think this PR removes support for any old versions.. but to test on older versions I'd have to make more changes to composer.lock.

Could you merge and release when you get a chance?

Happy new year!

b1rdex commented 3 years ago

composer.lock file should be removed. It doesn't do much in libraries.

afk11 commented 3 years ago

@b1rdex Agreed, I left it in the repo because it was there before me..

abgit commented 3 years ago

Can someone merge this? Otherwise all projects that use this lib are stuck on php7.

BafS commented 3 years ago

@lastguest would you be able to merge this PR please ? It's a blocker when we use this library with PHP 8. Otherwise we will have to fork it.

abgit commented 3 years ago

new tag too?