lastguest / murmurhash-php

PHP userland implementation of MurmurHash3
MIT License
128 stars 37 forks source link

PHP 5.6 also works with this but composer.json prevents using #9

Open softvar opened 4 years ago

softvar commented 4 years ago

I'm using PHP 5.6 in my project. I have been using this library by copy-pasting the code and it works. I wanted to use it via composer but composer.json requires to have PHP 7+.

Can we please update the composer.json to support 5.6 as well because code is working fine.

Thanks!

afk11 commented 4 years ago

You mustn't be copy-pasting master or a recent version, because this https://github.com/lastguest/murmurhash-php/blob/master/src/lastguest/Murmur.php#L24 (master) won't work on 5.6 for sure.

version 1.2.0 should work with 5.6