search

lastland / ScalaHDL2

The second version of ScalaHDL. Scala style!
6 stars 1 forks source link

get rid of the hard-coded IP addresses in tests #7

Closed lastland closed 9 years ago

lastland commented 9 years ago

Use something like localhost or 127.0.0.1 to replace the current hard-coded Ip addresses in tests, so the code can be tested on other machines (and CI servers).

It might also be a good idea to provide an alternative way to supply the IP address: using configuration files (by using, for example, Typesafe Config). This can be helpful in the following aspects:

  1. It will not require any modifications on code (hence no recompilation) when changing the IP address.
  2. Multiple test programs can share a single configuration file, which can minimize the efforts in changing the IP address for all test programs.
lastland commented 9 years ago

@Azard What do you think?

Azard commented 9 years ago

I see, previous hard-coded IP for temp test, I'll choose a better way to config IP.

Azard commented 9 years ago

Add global conf file, ref: https://github.com/lastland/ScalaHDL2/commit/b21a029d1a7f235f5c1a8ab5c82d9e23ae7ad2db