search

lastland / scala-forklift

Type-safe data migration tool for Slick, Git and beyond.
Other
188 stars 31 forks source link

Fix tests for scala 2.13 #50

Closed karolchmist closed 4 years ago

karolchmist commented 4 years ago

I've managed to fix tests on circleci-20-test branch. I took your commits @lastland and squashed them to just one for a starting point.

This fixed https://github.com/lastland/scala-forklift/issues/48

I just wanted at first to help and fix MySQL tests, but there were more things not working, so I took a deep dive and changed more stuff.

I hope that the commit messages are self-explanatory :)

The only thing that I'm not very happy about is using root user to run MySQL tests. I don't know why using env variables doesn't work, but maybe it could be fixed later. There is another solution of adding a user manually, which can be found on a separate branch.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

karolchmist commented 4 years ago

Circle CI built successfully

lastland commented 4 years ago

@karolchmist Thanks a lot for your contribution! This looks great. I'm merging it now and will publish a new version soon.

The use of root user is indeed a bit unsatisfying, but I think it is fine at the moment as this part of tests is supposed to mostly run on CIs. Thanks again!