lastlogin-io / obligator

Simple and opinionated OpenID Connect server designed for self-hosters
MIT License
637 stars 12 forks source link

Dockerfile improvement #20

Closed zhming0 closed 4 months ago

zhming0 commented 4 months ago

Thank you for making this software 🙂 . I am enjoying using it.

anderspitman commented 4 months ago

Hi @zhming0. Thanks for the contribution! I probably won't merge this because I prefer the alpine images. They're much smaller in my experience. If you want to make similar improvements to the alpine image, they would be welcome, but don't feel any obligation to do so. I'm happy to keep this open so others can find your dockerfile. I'm sure some would find it useful.

zhming0 commented 4 months ago

@anderspitman no problem at all. I changed it to Alpine now, please review 🙏🏿 . I love small image too 🙂.

FYI, in this case it's a 24MB vs 60MB difference.

anderspitman commented 4 months ago

Thanks @zhming0! I'll take a look soon. Since this Dockerfile is used for the production deployment I need to test and make sure it works.

anderspitman commented 4 months ago

Turns out I was wrong. I'm not currently using this Dockerfile for production. I did a quick review and just have a couple requests.

anderspitman commented 4 months ago

Sorry for the delay! Thanks again @zhming0