#48 ZIP file to PR, java runtime library

lastnpe / eclipse-null-eea-augments

Eclipse External null Annotations (EEA) repository

http://lastnpe.org

Eclipse Public License 2.0

41 stars 22 forks source link

#48 ZIP file to PR, java runtime library #56

Closed Bananeweizen closed 3 years ago

Bananeweizen commented 7 years ago

This is the merged ZIP file contribution for the Java runtime.

all signature changes of existing methods in java/java have been reviewed by me (and only 4 of the suggested changes were rejected by me).
changes in java/javax have not been reviewed.
new method signatures have not been reviewed (but will be crosschecked over the next days by using them in my own projects).

Bananeweizen commented 7 years ago

Note for reviewers: I've marked the 4 places with actual signature changes in the review. Everything else is just new or more annotations. So if you review those 4 places, you can afterwards accept and merge rather easily.

maggu2810 commented 7 years ago

I would give it a go. If there is some stuff wrong, it could be fixed later.

vorburger commented 6 years ago

@Bananeweizen are you planning to update this one some time, based on @sylvainlaurent feedback?

vorburger commented 4 years ago

If anyone is reading this and wants to rebase this PR and resolve merge conflicts, we could merge it.

vorburger commented 4 years ago

Maybe @simoneparca is interested? Given his #89.

J-N-K commented 3 years ago

I would really appreciate seeing the missing annotations, but since this did not have activity for a year now and can't be merged due to conflicts, I'm closing here. I promise that I'll review ASAP if someone comes up with a new PR for this.