search

lastnpe / eclipse-null-eea-augments

Eclipse External null Annotations (EEA) repository
http://lastnpe.org
Eclipse Public License 2.0
41 stars 22 forks source link

Null annotations for java.base/java.lang #85

Closed jason-faust closed 4 years ago

jason-faust commented 5 years ago

All public and protected members and methods Authored against OpenJDK 11.0.1 with Eclipse IDE 2018-12

jason-faust commented 5 years ago

I'll try to decipher the build errors tomorrow if I have time.

jason-faust commented 5 years ago

Not sure where to go with this.

Pushing things up to Java 11 requires some plugin changes, however runs into compatibility issues with java.xml.Bind being removed from the JDK. But even allowing that the build fails due to the hello project.

vorburger commented 4 years ago

The Travis CI build today only builds Java 8 (just fixed it). To proceed with this, you have to contribute a matrix build which also runs it under Java 11. Contributing is very welcome here!

J-N-K commented 4 years ago

I guess Travis fails because the methods are missing in Java 8.

jason-faust commented 4 years ago

@J-N-K from what @vorburger said, the build needs to be re-configured to support JDK 8 and 11 (and 14), which is impossible with just a simple switch to the matrix build (I tried).

J-N-K commented 4 years ago

The problem will be that we would have to add additional annotations so the tests know what the correct java version for this annotation is, otherwse the Java8 build will always fails.

Another solution would be to have two branches (and two releases), one for Java8 and one for Java 11. This would require cherry-picking compatible changes from the 11-branch to the 8-branch.

The easiest would be to change to Java11 now, since Java8 is now six years old and EOL (at least for Oracle versions),

J-N-K commented 4 years ago

@vorburger @kaikreuzer How can we proceed here? I would suggest to change Travis from Java 8 to Java 11 and merge here. A new release afterwards would be great.

vorburger commented 4 years ago

@vorburger @kaikreuzer How can we proceed here? I would suggest to change Travis from Java 8 to Java 11 and merge here. A new release afterwards would be great.

Thank You for your interest in LastNPE.org! While I currently do not have the spare cycles to continue contributing to actively maintain this community, I'm very happy to see both of your interests, and would hereby like to empower you to "carry the torch forward" - should you be interested to do so; see #91. Should you accept, feel free to change Travis - and go ahead making any other changes to this project you deem useful.