Fix non-default PKG_CONFIG_PATH on macOS

lastpass / lastpass-cli

LastPass command line interface tool

GNU General Public License v2.0

2.85k stars 292 forks source link

Fix non-default PKG_CONFIG_PATH on macOS #503

Closed alyssais closed 5 years ago

alyssais commented 5 years ago

PKG_CONFIG_PATH shouldn't be reset, only appended to or prepended to, so that the user can still use non-default paths if they need to. Additionally, package managers other than Homebrew (such as Nix) still need to be able to provide their own versions of packages, and aren't going to use Homebrew's default path to do so.

msbit commented 5 years ago

@GPaulovics, this fixes unintended consequences from the previous PKG_CONFIG_PATH fix I put in for macOS, and the issue will be hurting the Nix folks (as @alyssais mentioned) so it might be worth trying to get this released.

GPaulovics commented 5 years ago

@alyssais @msbit I just created a release specifically for this, and it is currently under review on brew as well. Sorry for taking this long.