search

lastpass / lastpass-cli

LastPass command line interface tool
GNU General Public License v2.0
2.85k stars 292 forks source link

Fix #464 #507

Closed jonathanlking closed 4 months ago

jonathanlking commented 5 years ago

This is an attempt to allow folders to be shared with groups that contain members without public/sharing keys and will fix #464. For such users we make a slightly different request, as used by the browser extension.

Running the command appears to add these groups correctly, and the users without public keys are able to access the passwords.

GPaulovics commented 5 years ago

Hey @jonathanlking Sorry for the late reply and thank you for your contribution. Could you please sign off your commit, as stated in the CONTRIBUTING guideline,so that i can merge it?

Thank You.

FloraMina commented 4 years ago

Hi @jonathanlking

We are facing the exact same issue as you did - I would greatly appreciate if you could sign off your PR so that it can be integrated in the next lastpass-cli release.

Cheers !

jonathanlking commented 4 years ago

Hi, apologies for taking so long to sign off the commit.

I want to add the disclaimer that although this worked for me last year (April-June 2019), I have not tested it recently. Additionally this fix was discovered through looking at the implementation of the browser extension, rather than any publicly available documentation.

FloraMina commented 4 years ago

Thanks a lot for everything @jonathanlking !

mateusmartins-lp commented 3 months ago

Regrettably, your PR submission was unintentionally closed during an operation, before we could complete our review and respond accordingly. Unable to revert it to 'Open' status, we invite you to resubmit your contribution at your earliest convenience. We apologize for this mishap. Rest assured, we value all contributions and remain dedicated to providing transparency and closure to the community. Thank you for your understanding.