Mark global variable as extern

[eclipseo]

GCC now defaults to -fno-common. As a result, global variable accesses are more efficient on various targets. In C, global variables with multiple tentative definitions now result in linker errors.

Fix #532

Signed-off-by: Robert-André Mauchin zebob.m@gmail.com

[alealv]

Thanks! work's great

[FrederikP]

Just ran into this using ubuntu/pop_os 20.10 Are you going to merge this at some point?

[mvanveen]

confirmed this fixes the issues I experienced on debian:bullseye-slim.

example Dockerfile:

FROM debian:bullseye-slim
RUN apt-get update
RUN apt-get --no-install-recommends -yqq install \
  bash-completion \
  build-essential \
  cmake \
  libcurl4  \
  libcurl4-openssl-dev  \
  libssl-dev  \
  libxml2 \
  libxml2-dev  \
  libssl1.1 \
  pkg-config \
  ca-certificates \
  xclip \
  git
WORKDIR /code
RUN git clone https://github.com/eclipseo/lastpass-cli.git
WORKDIR /code/lastpass-cli
RUN git checkout mark_global_var_as_extern
RUN make
RUN make install

CMD lpass

using the current master branch will reliably produce #532 whereas checking out @eclipseo's mark_global_var_as_extern branch fixes the issue and results in a successful compilation

[mvanveen]

thank you @eclipseo !

[mattalxndr]

What is the timeline for merging this in?

[lukebakken]

@eclipseo thank you for this patch. It allows me to compile this project on Ubuntu 22.04.

[TiborKLP]

Fix applied in d23846481066ea0a617a7338a3529e78b2eb517a