search

lastpass / lastpass-cli

LastPass command line interface tool
GNU General Public License v2.0
2.85k stars 292 forks source link

add-json-minified-lpass-ls-argument #572

Closed Lou486 closed 3 months ago

Lou486 commented 3 years ago

Added an option to allow lpass ls to output in minified JSON.

Closes #560

0xdevalias commented 1 year ago

This can be used with homebrew like follows:

⇒ brew edit lastpass-cli

Add the following:

  # JSON Minified Support: https://github.com/lastpass/lastpass-cli/pull/572
  patch do
    url "https://github.com/lastpass/lastpass-cli/pull/572/commits/1142db12cb774ed58328e567412c0727485a3b42.patch?full_index=1"
    sha256 ""
  end

Then re-install and build from source:

⇒  brew uninstall lastpass-cli

⇒  brew install --build-from-source lastpass-cli

Running this as follows:

⇒  lpass ls -j

Resulted in output that didn't seem to conform to typical JSON structure:

foo.example.com","id":123
bar.example.com","id":124
baz.example.com","id":125

It seems to be missing the leading/trailing { } to make it an object, as well as the start/end " quotes on each line

0xdevalias commented 3 months ago

@mateusmartins-lp It's good 'open source courtesy' to give context when closing an issue/PR, not just closing it with no explanation.

0xdevalias commented 3 months ago

@mateusmartins-lp It's good 'open source courtesy' to give context when closing an issue/PR, not just closing it with no explanation.

Hello @0xdevalias. The Pull Requests were closed unintentionally. By tomorrow I will be sure to leave a message on how to proceed. My sincere apologies for the inconvenience.

Originally posted by @mateusmartins-lp in https://github.com/lastpass/lastpass-cli/issues/553#issuecomment-2098844351

mateusmartins-lp commented 2 months ago

Regrettably, your PR submission was unintentionally closed during an operation, before we could complete our review and respond accordingly. Unable to revert it to 'Open' status, we invite you to resubmit your contribution at your earliest convenience. We apologize for this mishap. Rest assured, we value all contributions and remain dedicated to providing transparency and closure to the community. Thank you for your understanding.