Fix GCC 10+ build - Githubissues

lastpass / lastpass-cli

LastPass command line interface tool

GNU General Public License v2.0

2.85k stars 292 forks source link

Fix GCC 10+ build #576

Closed 1ace closed 2 years ago

1ace commented 3 years ago

GCC 10 changed the default option from -fcommon to -fno-common.

A quick and dirty fix could be to just set -fcommon in CMakeLists.txt, but the proper fix is to move the variables to a single compilation unit and simply reference them in the other CU, instead of each CU having its own copy.

Fixes #532 Fixes #599

bsutton commented 3 years ago

It would be really nice if the devs actually merged some of these PRs!!!