search

lastpass / lastpass-cli

LastPass command line interface tool
GNU General Public License v2.0
2.85k stars 292 forks source link

Fix sed for POSIX compliance. #583

Closed frossi-git closed 3 months ago

frossi-git commented 3 years ago

Current version of the sed command fails on macOS (tested version 11.0.1). The proposed change makes the command POSIX compliant

Signed-off-by: Filippo Rossi filippo.rossi@mailbox.org

frossi-git commented 3 years ago

Fixes #582

0xdevalias commented 1 year ago

See also:

0xdevalias commented 3 months ago

@mateusmartins-lp It's good 'open source courtesy' to give context when closing an issue/PR, not just closing it with no explanation.

0xdevalias commented 3 months ago

@mateusmartins-lp It's good 'open source courtesy' to give context when closing an issue/PR, not just closing it with no explanation.

Hello @0xdevalias. The Pull Requests were closed unintentionally. By tomorrow I will be sure to leave a message on how to proceed. My sincere apologies for the inconvenience.

Originally posted by @mateusmartins-lp in https://github.com/lastpass/lastpass-cli/issues/553#issuecomment-2098844351

mateusmartins-lp commented 2 months ago

Regrettably, your PR submission was unintentionally closed during an operation, before we could complete our review and respond accordingly. Unable to revert it to 'Open' status, we invite you to resubmit your contribution at your earliest convenience. We apologize for this mishap. Rest assured, we value all contributions and remain dedicated to providing transparency and closure to the community. Thank you for your understanding.