Add support for store and erase in the git credential helper

maelvls commented 3 years ago

The initial git-credential-lastpass was only answering to the get command, which meant the helper would not register new passwords, update existing ones or remove secrets that would not work.

This new version improves over the existing and will now properly register new secrets:

Peek 2020-12-19 14-04

In this patch, I also tried to lower the number of calls made to 'lpass' in order to keep a good performance:

When the password and the username are the same, 'store' does nothing;
A single lpass show is used to retrieve both password and username; that's because, for some reason, lpass hangs even between two consecutive show to the same secret.
Instead of using lpass ls (also sometimes hangs), I now use lpass status -q which seems to never hang.

maelvls commented 3 years ago

I just tried on macOS Catalina (10.15.7) and it won't work due to their /bin/bash being an old version from 2007 (GNU bash 3.2.57), associate arrays (declare -A params) were implemented in Bash 4...

Not sure how to work around this :(

mateusmartins-lp commented 2 months ago

Regrettably, your PR submission was unintentionally closed during an operation, before we could complete our review and respond accordingly. Unable to revert it to 'Open' status, we invite you to resubmit your contribution at your earliest convenience. We apologize for this mishap. Rest assured, we value all contributions and remain dedicated to providing transparency and closure to the community. Thank you for your understanding.

lastpass / lastpass-cli

Add support for store and erase in the git credential helper #587